Skip to content

Bump rexml from 3.3.4 to 3.3.6 in /examples/ruby #1886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 27, 2024

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Aug 22, 2024

Bumps rexml from 3.3.4 to 3.3.6.

Release notes

Sourced from rexml's releases.

REXML 3.3.6 - 2024-08-22

Improvements

  • Removed duplicated entity expansions for performance.

    • GH-194
    • Patch by Viktor Ivarsson.
  • Improved namespace conflicted attribute check performance. It was too slow for deep elements.

    • Reported by l33thaxor.

Fixes

  • Fixed a bug that default entity expansions are counted for security check. Default entity expansions should not be counted because they don't have a security risk.

  • Fixed a parser bug that parameter entity references in internal subsets are expanded. It's not allowed in the XML specification.

  • Fixed a stream parser bug that user-defined entity references in text aren't expanded.

Thanks

  • Viktor Ivarsson

  • NAITOH Jun

  • l33thaxor

REXML 3.3.5 - 2024-08-12

Fixes

  • Fixed a bug that REXML::Security.entity_expansion_text_limit check has wrong text size calculation in SAX and pull parsers.
    • GH-193
    • GH-195
    • Reported by Viktor Ivarsson.
    • Patch by NAITOH Jun.

... (truncated)

Changelog

Sourced from rexml's changelog.

3.3.6 - 2024-08-22 {#version-3-3-6}

Improvements

  • Removed duplicated entity expansions for performance.

    • GH-194
    • Patch by Viktor Ivarsson.
  • Improved namespace conflicted attribute check performance. It was too slow for deep elements.

    • Reported by l33thaxor.

Fixes

  • Fixed a bug that default entity expansions are counted for security check. Default entity expansions should not be counted because they don't have a security risk.

  • Fixed a parser bug that parameter entity references in internal subsets are expanded. It's not allowed in the XML specification.

  • Fixed a stream parser bug that user-defined entity references in text aren't expanded.

Thanks

  • Viktor Ivarsson

  • NAITOH Jun

  • l33thaxor

3.3.5 - 2024-08-12 {#version-3-3-5}

Fixes

  • Fixed a bug that REXML::Security.entity_expansion_text_limit check has wrong text size calculation in SAX and pull parsers.
    • GH-193
    • GH-195
    • Reported by Viktor Ivarsson.
    • Patch by NAITOH Jun.

... (truncated)

Commits
  • 95871f3 Add 3.3.6 entry
  • 7cb5eae parser tree: improve namespace conflicted attribute check performance
  • 6109e01 Fix a bug that Stream parser doesn't expand the user-defined entity reference...
  • cb15858 parser: keep the current namespaces instead of stack of Set
  • 2b47b16 parser: move duplicated end tag check to BaseParser
  • 35e1681 test tree-parser: move common method to base class
  • 6e00a14 test: fix indent
  • df3a0cc test: fix indent
  • fdbffe7 Use loop instead of recursive call for Element#namespace
  • 6422fa3 Use loop instead of recursive call for Element#root
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
    You can disable automated security fix PRs for this repo from the Security Alerts page.

Bumps [rexml](https://github.com/ruby/rexml) from 3.3.4 to 3.3.6.
- [Release notes](https://github.com/ruby/rexml/releases)
- [Changelog](https://github.com/ruby/rexml/blob/master/NEWS.md)
- [Commits](ruby/rexml@v3.3.4...v3.3.6)

---
updated-dependencies:
- dependency-name: rexml
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file ruby Pull requests that update Ruby code labels Aug 22, 2024
Copy link

netlify bot commented Aug 22, 2024

Deploy Preview for selenium-dev ready!

Name Link
🔨 Latest commit d808475
🔍 Latest deploy log https://app.netlify.com/sites/selenium-dev/deploys/66cc3778934608000969cf98
😎 Deploy Preview https://deploy-preview-1886--selenium-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

CI Failure Feedback 🧐

Action: tests (macos, nightly)

Failed stage: Run tests [❌]

Failed test name: Remote WebDriver starts remotely

Failure summary:

The action failed due to multiple errors in the Remote WebDriver tests:

  • The tests Remote WebDriver starts remotely, Remote WebDriver uploads, and Remote WebDriver downloads
    all encountered a TypeError.
  • The error message no implicit conversion of String into Integer indicates that there is an issue
    with the Selenium::Server.get method call, likely due to incorrect argument types being passed.
  • The failures occurred consistently across multiple attempts, suggesting a persistent issue in the
    test setup or code.

  • Relevant error logs:
    1:  ##[group]Operating System
    2:  macOS
    ...
    
    283:  timeout_minutes: 20
    284:  max_attempts: 3
    285:  command: cd examples/ruby
    286:  bundle exec rspec
    287:  
    288:  retry_wait_seconds: 10
    289:  polling_interval_seconds: 1
    290:  warning_on_retry: true
    291:  continue_on_error: false
    ...
    
    296:  PATH: /Users/runner/.local/bin:/opt/homebrew/bin:/opt/homebrew/sbin:/Users/runner/.cargo/bin:/usr/local/opt/curl/bin:/usr/local/bin:/usr/local/sbin:/Users/runner/bin:/Users/runner/.yarn/bin:/Users/runner/Library/Android/sdk/tools:/Users/runner/Library/Android/sdk/platform-tools:/Library/Frameworks/Python.framework/Versions/Current/bin:/Library/Frameworks/Mono.framework/Versions/Current/Commands:/usr/bin:/bin:/usr/sbin:/sbin:/Users/runner/.dotnet/tools
    297:  JAVA_HOME: /Users/runner/hostedtoolcache/Java_Temurin-Hotspot_jdk/11.0.24-8/arm64/Contents/Home
    298:  JAVA_HOME_11_ARM64: /Users/runner/hostedtoolcache/Java_Temurin-Hotspot_jdk/11.0.24-8/arm64/Contents/Home
    299:  ##[endgroup]
    300:  ......*.........................................................................***...*************...*.....*........*FFF....*******..........**************.............................
    301:  Pending: (Failures listed here are expected and do not affect your suite's status)
    302:  1) Keys copy and paste
    303:  # Test guarded; Guarded by {:browser=>:chrome, :reason=>"https://bugs.chromium.org/p/chromedriver/issues/detail?id=4264"};
    304:  Failure/Error: expect(driver.find_element(id: 'textInput').attribute('value')).to eq 'SeleniumSelenium!'
    ...
    
    423:  40) Element Locators with relative locators finds near element
    424:  # These are reference following the documentation example
    425:  # ./spec/elements/locators_spec.rb:55
    426:  41) Element Locators with relative locators chains relative locators
    427:  # These are reference following the documentation example
    428:  # ./spec/elements/locators_spec.rb:59
    429:  Failures:
    430:  1) Remote WebDriver starts remotely
    431:  Got 0 failures and 2 other errors:
    432:  1.1) Failure/Error:
    433:  Selenium::Server.get(:latest,
    434:  background: true,
    435:  args: %w[--selenium-manager true --enable-managed-downloads true])
    436:  TypeError:
    437:  no implicit conversion of String into Integer
    438:  # ./spec/drivers/remote_webdriver_spec.rb:10:in `block (2 levels) in <top (required)>'
    439:  # ./spec/drivers/remote_webdriver_spec.rb:16:in `block (2 levels) in <top (required)>'
    440:  1.2) Failure/Error:
    441:  Selenium::Server.get(:latest,
    442:  background: true,
    443:  args: %w[--selenium-manager true --enable-managed-downloads true])
    444:  TypeError:
    445:  no implicit conversion of String into Integer
    446:  # ./spec/drivers/remote_webdriver_spec.rb:10:in `block (2 levels) in <top (required)>'
    447:  # ./spec/drivers/remote_webdriver_spec.rb:17:in `block (2 levels) in <top (required)>'
    448:  2) Remote WebDriver uploads
    449:  Got 0 failures and 2 other errors:
    450:  2.1) Failure/Error:
    451:  Selenium::Server.get(:latest,
    452:  background: true,
    453:  args: %w[--selenium-manager true --enable-managed-downloads true])
    454:  TypeError:
    455:  no implicit conversion of String into Integer
    456:  # ./spec/drivers/remote_webdriver_spec.rb:10:in `block (2 levels) in <top (required)>'
    457:  # ./spec/drivers/remote_webdriver_spec.rb:16:in `block (2 levels) in <top (required)>'
    458:  2.2) Failure/Error:
    459:  Selenium::Server.get(:latest,
    460:  background: true,
    461:  args: %w[--selenium-manager true --enable-managed-downloads true])
    462:  TypeError:
    463:  no implicit conversion of String into Integer
    464:  # ./spec/drivers/remote_webdriver_spec.rb:10:in `block (2 levels) in <top (required)>'
    465:  # ./spec/drivers/remote_webdriver_spec.rb:17:in `block (2 levels) in <top (required)>'
    466:  3) Remote WebDriver downloads
    467:  Got 0 failures and 2 other errors:
    468:  3.1) Failure/Error:
    469:  Selenium::Server.get(:latest,
    470:  background: true,
    471:  args: %w[--selenium-manager true --enable-managed-downloads true])
    472:  TypeError:
    473:  no implicit conversion of String into Integer
    474:  # ./spec/drivers/remote_webdriver_spec.rb:10:in `block (2 levels) in <top (required)>'
    475:  # ./spec/drivers/remote_webdriver_spec.rb:16:in `block (2 levels) in <top (required)>'
    476:  3.2) Failure/Error:
    477:  Selenium::Server.get(:latest,
    478:  background: true,
    479:  args: %w[--selenium-manager true --enable-managed-downloads true])
    480:  TypeError:
    481:  no implicit conversion of String into Integer
    482:  # ./spec/drivers/remote_webdriver_spec.rb:10:in `block (2 levels) in <top (required)>'
    483:  # ./spec/drivers/remote_webdriver_spec.rb:17:in `block (2 levels) in <top (required)>'
    484:  Finished in 6 minutes 20 seconds (files took 7.17 seconds to load)
    485:  185 examples, 3 failures, 41 pending
    486:  Failed examples:
    487:  rspec ./spec/drivers/remote_webdriver_spec.rb:19 # Remote WebDriver starts remotely
    488:  rspec ./spec/drivers/remote_webdriver_spec.rb:26 # Remote WebDriver uploads
    489:  rspec ./spec/drivers/remote_webdriver_spec.rb:42 # Remote WebDriver downloads
    490:  ##[warning]Attempt 1 failed. Reason: Child_process exited with error code 1
    491:  ......*.........................................................................***...*************...*.....*........*FFF....*******..........**************.............................
    492:  Pending: (Failures listed here are expected and do not affect your suite's status)
    493:  1) Keys copy and paste
    494:  # Test guarded; Guarded by {:browser=>:chrome, :reason=>"https://bugs.chromium.org/p/chromedriver/issues/detail?id=4264"};
    495:  Failure/Error: expect(driver.find_element(id: 'textInput').attribute('value')).to eq 'SeleniumSelenium!'
    ...
    
    614:  40) Element Locators with relative locators finds near element
    615:  # These are reference following the documentation example
    616:  # ./spec/elements/locators_spec.rb:55
    617:  41) Element Locators with relative locators chains relative locators
    618:  # These are reference following the documentation example
    619:  # ./spec/elements/locators_spec.rb:59
    620:  Failures:
    621:  1) Remote WebDriver starts remotely
    622:  Got 0 failures and 2 other errors:
    623:  1.1) Failure/Error:
    624:  Selenium::Server.get(:latest,
    625:  background: true,
    626:  args: %w[--selenium-manager true --enable-managed-downloads true])
    627:  TypeError:
    628:  no implicit conversion of String into Integer
    629:  # ./spec/drivers/remote_webdriver_spec.rb:10:in `block (2 levels) in <top (required)>'
    630:  # ./spec/drivers/remote_webdriver_spec.rb:16:in `block (2 levels) in <top (required)>'
    631:  1.2) Failure/Error:
    632:  Selenium::Server.get(:latest,
    633:  background: true,
    634:  args: %w[--selenium-manager true --enable-managed-downloads true])
    635:  TypeError:
    636:  no implicit conversion of String into Integer
    637:  # ./spec/drivers/remote_webdriver_spec.rb:10:in `block (2 levels) in <top (required)>'
    638:  # ./spec/drivers/remote_webdriver_spec.rb:17:in `block (2 levels) in <top (required)>'
    639:  2) Remote WebDriver uploads
    640:  Got 0 failures and 2 other errors:
    641:  2.1) Failure/Error:
    642:  Selenium::Server.get(:latest,
    643:  background: true,
    644:  args: %w[--selenium-manager true --enable-managed-downloads true])
    645:  TypeError:
    646:  no implicit conversion of String into Integer
    647:  # ./spec/drivers/remote_webdriver_spec.rb:10:in `block (2 levels) in <top (required)>'
    648:  # ./spec/drivers/remote_webdriver_spec.rb:16:in `block (2 levels) in <top (required)>'
    649:  2.2) Failure/Error:
    650:  Selenium::Server.get(:latest,
    651:  background: true,
    652:  args: %w[--selenium-manager true --enable-managed-downloads true])
    653:  TypeError:
    654:  no implicit conversion of String into Integer
    655:  # ./spec/drivers/remote_webdriver_spec.rb:10:in `block (2 levels) in <top (required)>'
    656:  # ./spec/drivers/remote_webdriver_spec.rb:17:in `block (2 levels) in <top (required)>'
    657:  3) Remote WebDriver downloads
    658:  Got 0 failures and 2 other errors:
    659:  3.1) Failure/Error:
    660:  Selenium::Server.get(:latest,
    661:  background: true,
    662:  args: %w[--selenium-manager true --enable-managed-downloads true])
    663:  TypeError:
    664:  no implicit conversion of String into Integer
    665:  # ./spec/drivers/remote_webdriver_spec.rb:10:in `block (2 levels) in <top (required)>'
    666:  # ./spec/drivers/remote_webdriver_spec.rb:16:in `block (2 levels) in <top (required)>'
    667:  3.2) Failure/Error:
    668:  Selenium::Server.get(:latest,
    669:  background: true,
    670:  args: %w[--selenium-manager true --enable-managed-downloads true])
    671:  TypeError:
    672:  no implicit conversion of String into Integer
    673:  # ./spec/drivers/remote_webdriver_spec.rb:10:in `block (2 levels) in <top (required)>'
    674:  # ./spec/drivers/remote_webdriver_spec.rb:17:in `block (2 levels) in <top (required)>'
    675:  Finished in 7 minutes 19 seconds (files took 6.36 seconds to load)
    676:  185 examples, 3 failures, 41 pending
    677:  Failed examples:
    678:  rspec ./spec/drivers/remote_webdriver_spec.rb:19 # Remote WebDriver starts remotely
    679:  rspec ./spec/drivers/remote_webdriver_spec.rb:26 # Remote WebDriver uploads
    680:  rspec ./spec/drivers/remote_webdriver_spec.rb:42 # Remote WebDriver downloads
    681:  ##[warning]Attempt 2 failed. Reason: Child_process exited with error code 1
    682:  ......*.........................................................................***...*************...*.....*........*FFF....*******..........**************.............................
    683:  Pending: (Failures listed here are expected and do not affect your suite's status)
    684:  1) Keys copy and paste
    685:  # Test guarded; Guarded by {:browser=>:chrome, :reason=>"https://bugs.chromium.org/p/chromedriver/issues/detail?id=4264"};
    686:  Failure/Error: expect(driver.find_element(id: 'textInput').attribute('value')).to eq 'SeleniumSelenium!'
    ...
    
    805:  40) Element Locators with relative locators finds near element
    806:  # These are reference following the documentation example
    807:  # ./spec/elements/locators_spec.rb:55
    808:  41) Element Locators with relative locators chains relative locators
    809:  # These are reference following the documentation example
    810:  # ./spec/elements/locators_spec.rb:59
    811:  Failures:
    812:  1) Remote WebDriver starts remotely
    813:  Got 0 failures and 2 other errors:
    814:  1.1) Failure/Error:
    815:  Selenium::Server.get(:latest,
    816:  background: true,
    817:  args: %w[--selenium-manager true --enable-managed-downloads true])
    818:  TypeError:
    819:  no implicit conversion of String into Integer
    820:  # ./spec/drivers/remote_webdriver_spec.rb:10:in `block (2 levels) in <top (required)>'
    821:  # ./spec/drivers/remote_webdriver_spec.rb:16:in `block (2 levels) in <top (required)>'
    822:  1.2) Failure/Error:
    823:  Selenium::Server.get(:latest,
    824:  background: true,
    825:  args: %w[--selenium-manager true --enable-managed-downloads true])
    826:  TypeError:
    827:  no implicit conversion of String into Integer
    828:  # ./spec/drivers/remote_webdriver_spec.rb:10:in `block (2 levels) in <top (required)>'
    829:  # ./spec/drivers/remote_webdriver_spec.rb:17:in `block (2 levels) in <top (required)>'
    830:  2) Remote WebDriver uploads
    831:  Got 0 failures and 2 other errors:
    832:  2.1) Failure/Error:
    833:  Selenium::Server.get(:latest,
    834:  background: true,
    835:  args: %w[--selenium-manager true --enable-managed-downloads true])
    836:  TypeError:
    837:  no implicit conversion of String into Integer
    838:  # ./spec/drivers/remote_webdriver_spec.rb:10:in `block (2 levels) in <top (required)>'
    839:  # ./spec/drivers/remote_webdriver_spec.rb:16:in `block (2 levels) in <top (required)>'
    840:  2.2) Failure/Error:
    841:  Selenium::Server.get(:latest,
    842:  background: true,
    843:  args: %w[--selenium-manager true --enable-managed-downloads true])
    844:  TypeError:
    845:  no implicit conversion of String into Integer
    846:  # ./spec/drivers/remote_webdriver_spec.rb:10:in `block (2 levels) in <top (required)>'
    847:  # ./spec/drivers/remote_webdriver_spec.rb:17:in `block (2 levels) in <top (required)>'
    848:  3) Remote WebDriver downloads
    849:  Got 0 failures and 2 other errors:
    850:  3.1) Failure/Error:
    851:  Selenium::Server.get(:latest,
    852:  background: true,
    853:  args: %w[--selenium-manager true --enable-managed-downloads true])
    854:  TypeError:
    855:  no implicit conversion of String into Integer
    856:  # ./spec/drivers/remote_webdriver_spec.rb:10:in `block (2 levels) in <top (required)>'
    857:  # ./spec/drivers/remote_webdriver_spec.rb:16:in `block (2 levels) in <top (required)>'
    858:  3.2) Failure/Error:
    859:  Selenium::Server.get(:latest,
    860:  background: true,
    861:  args: %w[--selenium-manager true --enable-managed-downloads true])
    862:  TypeError:
    863:  no implicit conversion of String into Integer
    864:  # ./spec/drivers/remote_webdriver_spec.rb:10:in `block (2 levels) in <top (required)>'
    865:  # ./spec/drivers/remote_webdriver_spec.rb:17:in `block (2 levels) in <top (required)>'
    866:  Finished in 5 minutes 39 seconds (files took 3.53 seconds to load)
    867:  185 examples, 3 failures, 41 pending
    868:  Failed examples:
    869:  rspec ./spec/drivers/remote_webdriver_spec.rb:19 # Remote WebDriver starts remotely
    870:  rspec ./spec/drivers/remote_webdriver_spec.rb:26 # Remote WebDriver uploads
    871:  rspec ./spec/drivers/remote_webdriver_spec.rb:42 # Remote WebDriver downloads
    872:  ##[error]Final attempt failed. Child_process exited with error code 1
    

    ✨ CI feedback usage guide:

    The CI feedback tool (/checks) automatically triggers when a PR has a failed check.
    The tool analyzes the failed checks and provides several feedbacks:

    • Failed stage
    • Failed test name
    • Failure summary
    • Relevant error logs

    In addition to being automatically triggered, the tool can also be invoked manually by commenting on a PR:

    /checks "https://github.com/{repo_name}/actions/runs/{run_number}/job/{job_number}"
    

    where {repo_name} is the name of the repository, {run_number} is the run number of the failed check, and {job_number} is the job number of the failed check.

    Configuration options

    • enable_auto_checks_feedback - if set to true, the tool will automatically provide feedback when a check is failed. Default is true.
    • excluded_checks_list - a list of checks to exclude from the feedback, for example: ["check1", "check2"]. Default is an empty list.
    • enable_help_text - if set to true, the tool will provide a help message with the feedback. Default is true.
    • persistent_comment - if set to true, the tool will overwrite a previous checks comment with the new feedback. Default is true.
    • final_update_message - if persistent_comment is true and updating a previous checks message, the tool will also create a new message: "Persistent checks updated to latest commit". Default is true.

    See more information about the checks tool in the docs.

    Copy link
    Member

    @harsha509 harsha509 left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    LGTM!

    @harsha509 harsha509 merged commit de4ba9a into trunk Aug 27, 2024
    12 checks passed
    @harsha509 harsha509 deleted the dependabot/bundler/examples/ruby/rexml-3.3.6 branch August 27, 2024 08:06
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    dependencies Pull requests that update a dependency file ruby Pull requests that update Ruby code
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    1 participant